linux-kernel - RE: [PATCH wireless] wifi: rtw89: Un-embed dummy device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f46ae94488d1468e9a9a669320e4cfb9@realtek.com>
Date: Thu, 25 Apr 2024 05:52:54 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Breno Leitao <leitao@...ian.org>, Kalle Valo <kvalo@...nel.org>
CC: "leit@...a.com" <leit@...a.com>,
        "open list:REALTEK WIRELESS DRIVER
 (rtw89)" <linux-wireless@...r.kernel.org>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH wireless] wifi: rtw89: Un-embed dummy device

Breno Leitao <leitao@...ian.org> wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
> 
> Un-embed the net_device from the private struct by converting it
> into a pointer. Then use the leverage the new alloc_netdev_dummy()
> helper to allocate and initialize dummy devices.
> 
> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

I think this patch should go via net-next tree, because wireless-next tree
doesn't have patch of dummy devices yet.

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/core.c | 11 ++++++++---
>  drivers/net/wireless/realtek/rtw89/core.h |  4 ++--
>  drivers/net/wireless/realtek/rtw89/pci.c  |  6 +++++-
>  3 files changed, 15 insertions(+), 6 deletions(-)
> 
> PS: This is compile-tested only due to lack of hardware.

I picked this patch to local net-next tree, and tested on RTL8852BE, RTL8852C
and RTL8922AE.

Tested-by: Ping-Ke Shih <pkshih@...ltek.com>