linux-kernel - Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68489f85-5579-5cff-eed1-55ae585916f3@huawei.com>
Date: Thu, 25 Apr 2024 14:25:24 +0800
From: Miaohe Lin <linmiaohe@...wei.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Rasmus Villemoes <linux@...musvillemoes.dk>, Andrew Morton
	<akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function

On 2024/4/24 0:14, Andy Shevchenko wrote:
> In some configurations I got
> mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> Becuase the only user is guarged with a certain ifdeffery,

guarged? ifdeffery?

> do the same for add_to_free_list().

A Fixes tag might be needed.

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Anyway, this patch looks good to me. Thanks.

Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
Thanks.
.