linux-kernel - [PATCH] drivers:video: Implement automatic cleanup for device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Thu, 25 Apr 2024 07:32:54 +0000
From: Dorine Tipo <dorine.a.tipo@...il.com>
To: Helge Deller <deller@....de>,
	linux-fbdev@...r.kernel.org
Cc: Dorine Tipo <dorine.a.tipo@...il.com>,
	Julia Lawall <julia.lawall@...ia.fr>,
	Linux-kernel-mentees-request@...ts.linuxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] drivers:video: Implement automatic cleanup for device_node

This patch removes calls to of_node_put() and adds __free(device_node)
attribute to the device_node declaration in offb_init_palette_hacks().
This reduces the risk of memory leaks by ensuring that the reference
count is automatically managed and decremented when the device_node goes
out of scope.

Signed-off-by: Dorine Tipo <dorine.a.tipo@...il.com>
---
 drivers/video/fbdev/offb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
index b421b46d88ef..ea38a260774b 100644
--- a/drivers/video/fbdev/offb.c
+++ b/drivers/video/fbdev/offb.c
@@ -357,7 +357,7 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp
 			par->cmap_type = cmap_gxt2000;
 	} else if (of_node_name_prefix(dp, "vga,Display-")) {
 		/* Look for AVIVO initialized by SLOF */
-		struct device_node *pciparent = of_get_parent(dp);
+		struct device_node *pciparent __free(device_node) = of_get_parent(dp);
 		const u32 *vid, *did;
 		vid = of_get_property(pciparent, "vendor-id", NULL);
 		did = of_get_property(pciparent, "device-id", NULL);
@@ -369,7 +369,6 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp
 			if (par->cmap_adr)
 				par->cmap_type = cmap_avivo;
 		}
-		of_node_put(pciparent);
 	} else if (dp && of_device_is_compatible(dp, "qemu,std-vga")) {
 #ifdef __BIG_ENDIAN
 		const __be32 io_of_addr[3] = { 0x01000000, 0x0, 0x0 };
--
2.25.1