linux-kernel - Re: [PATCH v3 2/5] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f45a76b3-996f-4204-9b9c-289d40767708@linaro.org>
Date: Thu, 25 Apr 2024 11:16:42 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Niko Pasaloukos <nikolaos.pasaloukos@...ize.com>,
 "robh@...nel.org" <robh@...nel.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "catalin.marinas@....com" <catalin.marinas@....com>,
 "will@...nel.org" <will@...nel.org>, "arnd@...db.de" <arnd@...db.de>,
 "olof@...om.net" <olof@...om.net>, Neil Jones <neil.jones@...ize.com>,
 Matt Redfearn <matthew.redfearn@...ize.com>,
 James Cowgill <james.cowgill@...ize.com>,
 "heiko.stuebner@...rry.de" <heiko.stuebner@...rry.de>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "macromorgan@...mail.com" <macromorgan@...mail.com>,
 "sre@...nel.org" <sre@...nel.org>,
 "hvilleneuve@...onoff.com" <hvilleneuve@...onoff.com>,
 "andre.przywara@....com" <andre.przywara@....com>,
 "rafal@...ecki.pl" <rafal@...ecki.pl>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "andersson@...nel.org" <andersson@...nel.org>,
 "konrad.dybcio@...aro.org" <konrad.dybcio@...aro.org>,
 "geert+renesas@...der.be" <geert+renesas@...der.be>,
 "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
 "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
 "nfraprado@...labora.com" <nfraprado@...labora.com>,
 "u-kumar1@...com" <u-kumar1@...com>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC

On 25/04/2024 11:15, Niko Pasaloukos wrote:
> Add device tree bindings for the Blaize BLZP1600 CB2
> development board (carrier board), which uses the
> BLZP1600 SoM.
> 
> Reviewed-by: James Cowgill <james.cowgill@...ize.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@...ize.com>
> Reviewed-by: Neil Jones <neil.jones@...ize.com>
> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@...ize.com>
> ---
>  .../devicetree/bindings/arm/blaize.yaml       | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/blaize.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/blaize.yaml b/Documentation/devicetree/bindings/arm/blaize.yaml
> new file mode 100644
> index 000000000000..8034aeb7a2b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/blaize.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/blaize.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Blaize Platforms
> +
> +maintainers:
> +  - James Cowgill <james.cowgill@...ize.com>
> +  - Matt Redfearn <matt.redfearn@...ize.com>
> +  - Neil Jones <neil.jones@...ize.com>
> +  - Nikolaos Pasaloukos <nikolaos.pasaloukos@...ize.com>
> +
> +description: |
> +  Blaize Platforms using SoCs designed by Blaize Inc.
> +
> +  The products currently based on the BLZP1600 SoC:
> +
> +  - BLZP1600-SoM: SoM module
> +  - BLZP1600-CB2: Development board CB2 based on BLZP1600-SoM
> +
> +  The compatible property should follow the format:
> +
> +  compatible = "blaize,blzp1600-cb2", "blaize,blzp1600";

This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.

Best regards,
Krzysztof