linux-kernel - Re: linux-next: manual merge of the modules tree with the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240425113755.250be7a3@canb.auug.org.au>
Date: Thu, 25 Apr 2024 11:37:55 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: Mike Rapoport <rppt@...nel.org>, Andrew Morton
 <akpm@...ux-foundation.org>, Luis Chamberlain <mcgrof@...nel.org>, Linux
 Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Kent Overstreet <kent.overstreet@...ux.dev>
Subject: Re: linux-next: manual merge of the modules tree with the mm tree

Hi all,

On Wed, 24 Apr 2024 21:24:06 +0000 Suren Baghdasaryan <surenb@...gle.com> wrote:
>
> On Wed, Apr 24, 2024 at 8:33 PM Suren Baghdasaryan <surenb@...glecom> wrote:
> >
> > On Wed, Apr 24, 2024 at 1:31 PM Mike Rapoport <rppt@...nel.org> wrote:  
> > >
> > > On Wed, Apr 24, 2024 at 01:07:57PM -0700, Andrew Morton wrote:  
> > > > On Wed, 24 Apr 2024 12:39:35 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> > > >  
> > > > > Today's linux-next merge of the modules tree got a conflict in:
> > > > >
> > > > >   kernel/module/main.c
> > > > >
> > > > > between commits:
> > > > >
> > > > >   7f014cdda4cb ("lib: code tagging module support")
> > > > >   5ab9b0c7ea5c ("lib: prevent module unloading if memory is not freed")
> > > > >
> > > > > from the mm-unstable branch of the mm tree and commits:
> > > > >
> > > > >   0746f9982603 ("module: make module_memory_{alloc,free} more self-contained")
> > > > >   18da532eefc8 ("mm/execmem, arch: convert remaining overrides of module_alloc to execmem")
> > > > >
> > > > > from the modules tree.
> > > > >
> > > > > I fixed it up (I think, see below) and can carry the fix as
> > > > > necessary. This is now fixed as far as linux-next is concerned, but any
> > > > > non trivial conflicts should be mentioned to your upstream maintainer
> > > > > when your tree is submitted for merging.  You may also want to consider
> > > > > cooperating with the maintainer of the conflicting tree to minimise any
> > > > > particularly complex conflicts.  
> > > >
> > > > That's a shame.  I don't see much that we can do to reduce the damage here.  
> > >
> > > I can rebase it on mm-unstable and this can go via the mm tree.  
> >
> > Conflict resolution looks fine to me. I'll run relevant tests on
> > linux-next within 2 hours.  
> 
> Tests are passing and module loading/unloading works fine on linux-next.

Unfortunately, due to a failure in my boot tests, the new (conficting)
part of the modules tree was not included in linux-next yesterday.

See https://lore.kernel.org/all/20240424183503.2a6ce847@canb.auug.org.au/

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped