linux-kernel - Re: [PATCH] video: fbdev: replacing of_node_put with __free(device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <784db573-5903-4c13-b0ad-fdeeb7b649de@gmx.de>
Date: Thu, 25 Apr 2024 12:13:33 +0200
From: Helge Deller <deller@....de>
To: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>, sam@...nborg.org,
 tzimmermann@...e.de, christophe.jaillet@...adoo.fr,
 u.kleine-koenig@...gutronix.de, julia.lawall@...ia.fr
Cc: linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
 javier.carrasco.cruz@...il.com
Subject: Re: [PATCH] video: fbdev: replacing of_node_put with
 __free(device_node)

On 4/23/24 03:20, Abdulrasaq Lawani wrote:
> Replaced instance of of_node_put with __free(device_node)
> to simplify code and protect against any memory leaks
> due to future changes in the control flow.
>
> Suggested-by: Julia Lawall <julia.lawall@...ia.fr>
> Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>

applied.
Thanks!

Helge

> ---
>   drivers/video/fbdev/offb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c
> index b421b46d88ef..ea38a260774b 100644
> --- a/drivers/video/fbdev/offb.c
> +++ b/drivers/video/fbdev/offb.c
> @@ -357,7 +357,7 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp
>   			par->cmap_type = cmap_gxt2000;
>   	} else if (of_node_name_prefix(dp, "vga,Display-")) {
>   		/* Look for AVIVO initialized by SLOF */
> -		struct device_node *pciparent = of_get_parent(dp);
> +		struct device_node *pciparent __free(device_node) = of_get_parent(dp);
>   		const u32 *vid, *did;
>   		vid = of_get_property(pciparent, "vendor-id", NULL);
>   		did = of_get_property(pciparent, "device-id", NULL);
> @@ -369,7 +369,6 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp
>   			if (par->cmap_adr)
>   				par->cmap_type = cmap_avivo;
>   		}
> -		of_node_put(pciparent);
>   	} else if (dp && of_device_is_compatible(dp, "qemu,std-vga")) {
>   #ifdef __BIG_ENDIAN
>   		const __be32 io_of_addr[3] = { 0x01000000, 0x0, 0x0 };