linux-kernel - Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe21919b-a253-679a-5d6c-e4278a97a2a9@huawei.com>
Date: Thu, 25 Apr 2024 19:23:12 +0800
From: Miaohe Lin <linmiaohe@...wei.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Rasmus Villemoes <linux@...musvillemoes.dk>, Andrew Morton
	<akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function

On 2024/4/25 17:45, Andy Shevchenko wrote:
> On Thu, Apr 25, 2024 at 12:15:32PM +0300, Andy Shevchenko wrote:
>> On Thu, Apr 25, 2024 at 02:25:24PM +0800, Miaohe Lin wrote:
>>> On 2024/4/24 0:14, Andy Shevchenko wrote:
> 
> ...
> 
>>>> In some configurations I got
>>>> mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
>>>> Becuase the only user is guarged with a certain ifdeffery,
>>>
>>> guarged?
>>
>> A typo, thanks!
> 
> FWIW, Andrew fixed this along with "Because". Thank you, Andrew!

Got it. Thanks both.
.

> 
>>> ifdeffery?
>>
>> Yes, this is established term.
>>
>>>> do the same for add_to_free_list().
>