linux-kernel - Re: [PATCH] wifi: brcmfmac: remove unused brcmf_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71e03d9f-32ae-4cdb-982e-4ea0b8c699b8@broadcom.com>
Date: Thu, 25 Apr 2024 13:49:33 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Kalle Valo <kvalo@...nel.org>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com
Subject: Re: [PATCH] wifi: brcmfmac: remove unused brcmf_usb_image struct

On 4/25/2024 12:03 PM, Christophe JAILLET wrote:
> struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5
> ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated
> in commit 803599d40418 ("brcmfmac: store usb fw images in local linked
> list.")
> 
> Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove
> firmware list from USB driver").
> 
> Remove the structure definition now. This saves a few lines of code.

Thanks for the cleanup/

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> index 0ccf735316c2..9a105e6debe1 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
> @@ -117,13 +117,6 @@ struct bootrom_id_le {
>   	__le32 boardrev;	/* Board revision */
>   };
>   
> -struct brcmf_usb_image {
> -	struct list_head list;
> -	s8 *fwname;
> -	u8 *image;
> -	int image_len;
> -};
> -
>   struct brcmf_usbdev_info {
>   	struct brcmf_usbdev bus_pub; /* MUST BE FIRST */
>   	spinlock_t qlock;

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)