linux-kernel - Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a834a59d-9f31-4374-923f-ddd89780b62a@redhat.com>
Date: Thu, 25 Apr 2024 08:24:46 -0400
From: Waiman Long <longman@...hat.com>
To: Xiu Jianfeng <xiujianfeng@...wei.com>, lizefan.x@...edance.com,
 tj@...nel.org, hannes@...xchg.org
Cc: cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in
 sched_partition_write()

On 4/25/24 05:30, Xiu Jianfeng wrote:
> The comment here is outdated and can cause confusion, from the code
> perspective, there’s also no need for new comment, so just remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
> ---
>   kernel/cgroup/cpuset.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index f5443c039619..a10e4bd0c0c1 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3774,9 +3774,6 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,
>   
>   	buf = strstrip(buf);
>   
> -	/*
> -	 * Convert "root" to ENABLED, and convert "member" to DISABLED.
> -	 */
>   	if (!strcmp(buf, "root"))
>   		val = PRS_ROOT;
>   	else if (!strcmp(buf, "member"))

Yes, that comment is now no longer relevant.

Acked-by: Waiman Long <longman@...hat.com>