linux-kernel - Re: [PATCH v5 4/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <daa4f927-3412-2392-f5ca-e27ad550377c@huawei.com>
Date: Thu, 25 Apr 2024 20:55:49 +0800
From: liulongfang <liulongfang@...wei.com>
To: kernel test robot <lkp@...el.com>, <alex.williamson@...hat.com>,
	<jgg@...dia.com>, <shameerali.kolothum.thodi@...wei.com>,
	<jonathan.cameron@...wei.com>
CC: <oe-kbuild-all@...ts.linux.dev>, <kvm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linuxarm@...neuler.org>
Subject: Re: [PATCH v5 4/5] hisi_acc_vfio_pci: register debugfs for hisilicon
 migration driver

On 2024/4/25 17:20, kernel test robot wrote:
> Hi Longfang,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on awilliam-vfio/next]
> [also build test ERROR on linus/master v6.9-rc5 next-20240424]
> [cannot apply to awilliam-vfio/for-linus]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Longfang-Liu/hisi_acc_vfio_pci-extract-public-functions-for-container_of/20240424-170806
> base:   https://github.com/awilliam/linux-vfio.git next
> patch link:    https://lore.kernel.org/r/20240424085721.12760-5-liulongfang%40huawei.com
> patch subject: [PATCH v5 4/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
> config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20240425/202404251733.qOuGkmpU-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240425/202404251733.qOuGkmpU-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404251733.qOuGkmpU-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c: In function 'hisi_acc_vf_debug_cmd':
>>> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1370:53: error: macro "dev_err" requires 3 arguments, but only 1 given
>     1370 |         dev_err("mailbox cmd channel state is OK!\n");
>          |                                                     ^
>    In file included from include/linux/device.h:15,
>                     from drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:6:
>    include/linux/dev_printk.h:143: note: macro "dev_err" defined here
>      143 | #define dev_err(dev, fmt, ...) \
>          | 
>>> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1370:9: error: 'dev_err' undeclared (first use in this function); did you mean '_dev_err'?
>     1370 |         dev_err("mailbox cmd channel state is OK!\n");
>          |         ^~~~~~~
>          |         _dev_err
>    drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1370:9: note: each undeclared identifier is reported only once for each function it appears in
> 
> 
> vim +/dev_err +1370 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> 
>   1345	
>   1346	static int hisi_acc_vf_debug_cmd(struct seq_file *seq, void *data)
>   1347	{
>   1348		struct device *vf_dev = seq->private;
>   1349		struct vfio_pci_core_device *core_device = dev_get_drvdata(vf_dev);
>   1350		struct vfio_device *vdev = &core_device->vdev;
>   1351		struct hisi_acc_vf_core_device *hisi_acc_vdev = hisi_acc_get_vf_dev(vdev);
>   1352		struct hisi_qm *vf_qm = &hisi_acc_vdev->vf_qm;
>   1353		u64 value;
>   1354		int ret;
>   1355	
>   1356		mutex_lock(&hisi_acc_vdev->enable_mutex);
>   1357		ret = hisi_acc_vf_debug_check(seq, vdev);
>   1358		if (ret) {
>   1359			mutex_unlock(&hisi_acc_vdev->enable_mutex);
>   1360			return ret;
>   1361		}
>   1362	
>   1363		value = readl(vf_qm->io_base + QM_MB_CMD_SEND_BASE);
>   1364		if (value == QM_MB_CMD_NOT_READY) {
>   1365			mutex_unlock(&hisi_acc_vdev->enable_mutex);
>   1366			dev_err(vf_dev, "mailbox cmd channel not ready!\n");
>   1367			return -EINVAL;
>   1368		}
>   1369		mutex_unlock(&hisi_acc_vdev->enable_mutex);
>> 1370		dev_err("mailbox cmd channel state is OK!\n");
>   1371	
>   1372		return 0;
>   1373	}
>   1374	
>

OK,
I'll modify it soon.

Thanks.
Longfang.