linux-kernel - Re: [PATCH 3/4] i2c: ali1563: remove printout on handled timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 25 Apr 2024 17:23:38 +0200
From: Jean Delvare <jdelvare@...e.de>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-i2c@...r.kernel.org, Rudolf Marek <r.marek@...embler.cz>, Andi
 Shyti <andi.shyti@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] i2c: ali1563: remove printout on handled timeouts

On Tue, 23 Apr 2024 14:13:20 +0200, Wolfram Sang wrote:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The controller
> should just pass this information upwards. Remove the printout.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/i2c/busses/i2c-ali1563.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c
> index 307fb0666ecb..63897a89bb35 100644
> --- a/drivers/i2c/busses/i2c-ali1563.c
> +++ b/drivers/i2c/busses/i2c-ali1563.c
> @@ -99,7 +99,6 @@ static int ali1563_transaction(struct i2c_adapter *a, int size)
>  		return 0;
>  
>  	if (!timeout) {
> -		dev_err(&a->dev, "Timeout - Trying to KILL transaction!\n");
>  		/* Issue 'kill' to host controller */
>  		outb_p(HST_CNTL2_KILL, SMB_HST_CNTL2);
>  		data = inb_p(SMB_HST_STS);

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support