linux-kernel - Re: [PATCH v4 20/71] perf/x86/intel/pt: Switch to new Intel CPU model defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62b58fca-26ff-4c86-96a5-a1ec2b541437@intel.com>
Date: Thu, 25 Apr 2024 08:58:41 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
 Thomas Gleixner <tglx@...utronix.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>, "H. Peter Anvin" <hpa@...or.com>,
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev
Subject: Re: [PATCH v4 20/71] perf/x86/intel/pt: Switch to new Intel CPU model
 defines

On 4/24/24 11:15, Tony Luck wrote:
>  	/* model-specific quirks */
> -	switch (boot_cpu_data.x86_model) {
> -	case INTEL_FAM6_BROADWELL:
> -	case INTEL_FAM6_BROADWELL_D:
> -	case INTEL_FAM6_BROADWELL_G:
> -	case INTEL_FAM6_BROADWELL_X:
> +	switch (boot_cpu_data.x86_vfm) {
> +	case INTEL_BROADWELL:
> +	case INTEL_BROADWELL_D:
> +	case INTEL_BROADWELL_G:
> +	case INTEL_BROADWELL_X:
>  		/* not setting BRANCH_EN will #GP, erratum BDM106 */
>  		pt_pmu.branch_en_always_on = true;
>  		break;

Hah, and this actually fixes a theoretical bug because there's no check
for family 6 in this code.