linux-kernel - Re: [PATCH v3 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240426-fifteen-random-ff4a535ab40d@spud>
Date: Fri, 26 Apr 2024 18:06:25 +0100
From: Conor Dooley <conor@...nel.org>
To: cong yang <yangcong5@...qin.corp-partner.google.com>
Cc: sam@...nborg.org, neil.armstrong@...aro.org, daniel@...ll.ch,
	dianders@...omium.org, linus.walleij@...aro.org,
	krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
	conor+dt@...nel.org, airlied@...il.com,
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	xuxinxiong@...qin.corp-partner.google.com
Subject: Re: [PATCH v3 1/7] dt-bindings: display: panel: Add himax hx83102
 panel bindings

On Thu, Apr 25, 2024 at 02:03:24PM +0800, cong yang wrote:
> Conor Dooley <conor@...nel.org> 于2024年4月25日周四 00:55写道：
> > On Wed, Apr 24, 2024 at 10:30:04AM +0800, Cong Yang wrote:

> > > +++ b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> >
> > Filename matching a compatible please. What you've done here makes it
> > seem like there's a fallback compatible missing, given this looks like
> > the LCD panel controller and the starry compatible below is an LCD panel.
> 
> So change the filename to starry,himax83102-j02.yaml?

IDK chief, are you missing a fallback or not?

> 
> >
> > > @@ -0,0 +1,73 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/himax,hx83102.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Himax HX83102 MIPI-DSI LCD panel controller

Because the title here makes it seem like there should be.

> > > +maintainers:
> > > +  - Cong Yang <yangcong5@...qin.corp-partner.google.com>
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +        # STARRY himax83102-j02 10.51" WUXGA TFT LCD panel
> > > +      - starry,himax83102-j02
> > > +
> > > +  reg:
> > > +    description: the virtual channel number of a DSI peripheral
> > > +
> > > +  enable-gpios:
> > > +    description: a GPIO spec for the enable pin
> > > +
> > > +  pp1800-supply:
> > > +    description: core voltage supply
> > > +
> > > +  avdd-supply:
> > > +    description: phandle of the regulator that provides positive voltage
> > > +
> > > +  avee-supply:
> > > +    description: phandle of the regulator that provides negative voltage
> > > +
> > > +  backlight:
> > > +    description: phandle of the backlight device attached to the panel
> >
> > I'm not sure why this was given a description when port or rotation
> > was not.
> 
> So change it to backlight: true ?

Sure? It is just a repeat of something already described in
panel-common.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)