linux-kernel - Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 26 Apr 2024 19:23:08 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, marcel@...tmann.org, krzysztof.kozlowski@...aro.org, 
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org, 
	wt@...guintechs.org, quic_zijuhu@...cinc.com
Subject: Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL
 returned by gpiod_get_optional()

On Fri, 26 Apr 2024 at 17:09, Luiz Augusto von Dentz
<luiz.dentz@...il.com> wrote:
>
> Hi Bartosz,
>
> On Fri, Apr 26, 2024 at 10:37 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >
> > On Wed, 24 Apr 2024 17:40:27 +0200, patchwork-bot+bluetooth@...nel.org said:
> > > Hello:
> > >
> > > This patch was applied to bluetooth/bluetooth-next.git (master)
> > > by Luiz Augusto von Dentz <luiz.von.dentz@...el.com>:
> > >
> > > On Wed, 24 Apr 2024 14:29:32 +0200 you wrote:
> > >> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > >>
> > >> Any return value from gpiod_get_optional() other than a pointer to a
> > >> GPIO descriptor or a NULL-pointer is an error and the driver should
> > >> abort probing. That being said: commit 56d074d26c58 ("Bluetooth: hci_qca:
> > >> don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets
> > >> power_ctrl_enabled on NULL-pointer returned by
> > >> devm_gpiod_get_optional(). Restore this behavior but bail-out on errors.
> > >> While at it: also bail-out on error returned when trying to get the
> > >> "swctrl" GPIO.
> > >>
> > >> [...]
> > >
> > > Here is the summary with links:
> > >   - [v2] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional()
> > >     https://git.kernel.org/bluetooth/bluetooth-next/c/48a9e64a533b
> > >
> > > You are awesome, thank you!
> > > --
> > > Deet-doot-dot, I am a bot.
> > > https://korg.docs.kernel.org/patchwork/pwbot.html
> > >
> > >
> > >
> >
> > Luiz,
> >
> > I think patchwork borked when picking up this one, here's what the commit
> > trailer looks like in next:
> >
> >     Reported-by: Wren Turkal <wt@...guintechs.org>
> >     Reported-by: Zijun Hu <quic_zijuhu@...cinc.com>
> >     Closes: https://lore.kernel.org/linux-bluetooth/1713449192-25926-2-git-send-email-quic_zijuhu@quicinc.com/
> >     Fixes: 56d074d26c58 ("Bluetooth: hci_qca: don't use
> > IS_ERR_OR_NULL() with gpiod_get_optional()")
> >     Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >     Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >     Tested-by: Wren Turkal" <wt@...guintechs.org>
> >     Reported-by: Wren Turkal <wt@...guintechs.org>
> >     Reported-by: Zijun Hu <quic_zijuhu@...cinc.com>
> >     Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@...aro.org>
> >     Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >     Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>
> >
> > Reported-by and Reviewed-by tags are duplicated. One of the RB tags is missing
> > a space.
>
> Oh crap, should probably not trust patchwork would pick up the tags
> properly, that said the pull-request was already merged, not sure if
> we can do something about it now?
>

Nope, if it's gone upstream then it's too late.

BTW As a fresh b4 convert I highly recommend it for managing patches. :)

Bart

> --
> Luiz Augusto von Dentz