linux-kernel - Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32ec3ef4-0ecc-4ae2-bf76-c7b10f54a583@solid-run.com>
Date: Fri, 26 Apr 2024 18:51:02 +0000
From: Josua Mayer <josua@...id-run.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Gregory Clement <gregory.clement@...tlin.com>, Sebastian Hesselbarth
	<sebastian.hesselbarth@...il.com>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
	<conor+dt@...nel.org>, Rob Herring <robh@...nel.org>, Yazan Shhady
	<yazan.shhady@...id-run.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131
 solidwan board

Am 26.04.24 um 20:18 schrieb Andrew Lunn:
>>>> Colours are similar to RJ45 connectors (yellow, green),
>>>> and are intended for the same purpose: link, activity.
>>> For the switch LEDs you used label = "LED10"; Does the silk screen
>>> have similar numbers for these LEDs?
>> Correct, on CN9130 Clearfog Pro DSA switch, all LEDs are labeled
>> individually on the silk screen.
>>
>> The SolidWAN SFP leds are dual-colour leds with 3 terminals:
>> anode to 3.3V, 2x cathode to gpio-controlled transistors.
>> They are labeled on the silk-screen as "LED9", "LED10".
>>
>> Duplicate labels are not great, is there a better way?
>> old style "LED9:green" e.g. ...?
> So you have copper LEDs and SFP LEDs, each with the same silk screen
> label? Maybe put 'copper' and 'sfp' as a prefix into the label?

No, not quite.

We have 2x SFP Connectors.
On the bottom side of PCB immediately below each connector is
a single LED (as in physical component), each with a silk-screen label.

"J28"/"SFP 0": "LED10"
"J42"/"SFP 1": "LED9"

The problem is that these leds are each two leds in single-package,
which is why I put 4 led nodes in dts, two labeled "sfp-0",
other two "sfp-1".
But I don't think this duplication of label in dts is a good idea.