linux-kernel - Re: [PATCH v1 1/5] selftests/pidfd: Fix config for pidfd_setns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202404261236.EDA64763@keescook>
Date: Fri, 26 Apr 2024 12:37:13 -0700
From: Kees Cook <keescook@...omium.org>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Christian Brauner <brauner@...nel.org>,
	Jakub Kicinski <kuba@...nel.org>, Mark Brown <broonie@...nel.org>,
	Shengyu Li <shengyu.li.evgeny@...il.com>,
	Shuah Khan <shuah@...nel.org>,
	"David S . Miller" <davem@...emloft.net>,
	Günther Noack <gnoack@...gle.com>,
	Will Drewry <wad@...omium.org>,
	kernel test robot <oliver.sang@...el.com>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v1 1/5] selftests/pidfd: Fix config for pidfd_setns_test

On Fri, Apr 26, 2024 at 07:22:48PM +0200, Mickaël Salaün wrote:
> Required by switch_timens() to open /proc/self/ns/time_for_children.
> 
> CONFIG_GENERIC_VDSO_TIME_NS is not available on UML, so pidfd_setns_test
> cannot be run successfully on this architecture.
> 
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Fixes: 2b40c5db73e2 ("selftests/pidfd: add pidfd setns tests")
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>

Ah, UML continues to be a bit weird. :)

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook