linux-kernel - RE: [PATCH v2 2/2] drm: xlnx: zynqmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MW4PR12MB716503F7F5668AF9B054C2DDE6162@MW4PR12MB7165.namprd12.prod.outlook.com>
Date: Fri, 26 Apr 2024 19:46:56 +0000
From: "Klymenko, Anatoliy" <Anatoliy.Klymenko@....com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>, Laurent
 Pinchart <laurent.pinchart@...asonboard.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
	Daniel Vetter <daniel@...ll.ch>, "Simek, Michal" <michal.simek@....com>
Subject: RE: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error



> -----Original Message-----
> From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Sent: Thursday, April 25, 2024 11:36 PM
> To: Klymenko, Anatoliy <Anatoliy.Klymenko@....com>
> Cc: dri-devel@...ts.freedesktop.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; kernel test robot <lkp@...el.com>; Laurent
> Pinchart <laurent.pinchart@...asonboard.com>; Maarten Lankhorst
> <maarten.lankhorst@...ux.intel.com>; Maxime Ripard
> <mripard@...nel.org>; Thomas Zimmermann <tzimmermann@...e.de>;
> David Airlie <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>;
> Simek, Michal <michal.simek@....com>
> Subject: Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation
> error
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On 26/04/2024 04:46, Anatoliy Klymenko wrote:
> > Fix W=1 clang 19 compilation error in
> zynqmp_disp_layer_drm_formats().
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-
> lkp@...el.com/
> > ---
> 
> This is missing your signed-off-by.
> 
>   Tomi

Thank you!

> 
> >   drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index 423f5f4943cc..c9fb432d4cbd 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -981,7 +981,7 @@ u32 *zynqmp_disp_layer_drm_formats(struct
> zynqmp_disp_layer *layer,
> >       unsigned int i;
> >       u32 *formats;
> >
> > -     if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> > +     if (WARN_ON(layer->mode != ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> >               *num_formats = 0;
> >               return NULL;
> >       }
> >