[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240426202532.27848-1-tttturtleruss@hust.edu.cn>
Date: Sat, 27 Apr 2024 04:25:32 +0800
From: Haoyang Liu <tttturtleruss@...t.edu.cn>
To: Luis Chamberlain <mcgrof@...nel.org>,
Russ Weight <russ.weight@...ux.dev>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>
Cc: hust-os-kernel-patches@...glegroups.com,
Haoyang Liu <tttturtleruss@...t.edu.cn>,
Dan Carpenter <dan.carpenter@...aro.org>,
linux-kernel@...r.kernel.org
Subject: [PATCH] firmware_loader: Replace simple_strtol() with kstrtoint()
simple_strtol() is obsolete, use kstrtoint() instead.
Signed-off-by: Haoyang Liu <tttturtleruss@...t.edu.cn>
Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
---
drivers/base/firmware_loader/sysfs.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/base/firmware_loader/sysfs.c b/drivers/base/firmware_loader/sysfs.c
index c9c93b47d9a5..4de1cb243bee 100644
--- a/drivers/base/firmware_loader/sysfs.c
+++ b/drivers/base/firmware_loader/sysfs.c
@@ -47,8 +47,12 @@ static ssize_t timeout_show(const struct class *class, const struct class_attrib
static ssize_t timeout_store(const struct class *class, const struct class_attribute *attr,
const char *buf, size_t count)
{
- int tmp_loading_timeout = simple_strtol(buf, NULL, 10);
+ int tmp_loading_timeout;
+ int res;
+ res = kstrtoint(buf, 10, &tmp_loading_timeout);
+ if (res < 0)
+ return res;
if (tmp_loading_timeout < 0)
tmp_loading_timeout = 0;
@@ -157,8 +161,12 @@ static ssize_t firmware_loading_store(struct device *dev,
struct fw_sysfs *fw_sysfs = to_fw_sysfs(dev);
struct fw_priv *fw_priv;
ssize_t written = count;
- int loading = simple_strtol(buf, NULL, 10);
+ int loading;
+ int res;
+ res = kstrtoint(buf, 10, &loading);
+ if (res < 0)
+ return res;
mutex_lock(&fw_lock);
fw_priv = fw_sysfs->fw_priv;
if (fw_state_is_aborted(fw_priv) || fw_state_is_done(fw_priv))
--
2.25.1
Powered by blists - more mailing lists