linux-kernel - Re: [PATCH net] net: wwan: Add net device name for error message print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f7c4b67-a6bd-4fc2-a7da-e4bb0c2b6f50@lunn.ch>
Date: Sat, 27 Apr 2024 00:21:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Slark Xiao <slark_xiao@....com>
Cc: loic.poulain@...aro.org, ryazanov.s.a@...il.com,
	johannes@...solutions.net, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: wwan: Add net device name for error message
 print

>  	if (skb->len < sizeof(struct usb_cdc_ncm_nth16) +
>  			sizeof(struct usb_cdc_ncm_ndp16)) {
> -		net_err_ratelimited("frame too short\n");
> +		net_err_ratelimited("mbim: frame too short\n");

I don't know this code at all, but i think you can do

dev_err_ratelimited(&mbim->mdev->dev, "frame too short\n");

That way, it tells you which of the 42 mhi devices has received too
short a frame.

      Andrew