linux-kernel - Re: [PATCH v2] wifi: carl9170: add a proper sanity check for endpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734r8sorx.fsf@kernel.org>
Date: Fri, 26 Apr 2024 07:58:58 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Christian Lamparter <chunkeey@...il.com>
Cc: Nikita Zhandarovich <n.zhandarovich@...tech.ru>,
  linux-wireless@...r.kernel.org,  linux-kernel@...r.kernel.org,
  syzkaller-bugs@...glegroups.com,  lvc-project@...uxtesting.org,
  syzbot+0ae4804973be759fa420@...kaller.appspotmail.com
Subject: Re: [PATCH v2] wifi: carl9170: add a proper sanity check for endpoints

Christian Lamparter <chunkeey@...il.com> writes:

> On 4/22/24 8:33 PM, Nikita Zhandarovich wrote:
>> Syzkaller reports [1] hitting a warning which is caused by presence
>> of a wrong endpoint type at the URB sumbitting stage. While there
>> was a check for a specific 4th endpoint, since it can switch types
>> between bulk and interrupt, other endpoints are trusted implicitly.
>> Similar warning is triggered in a couple of other syzbot issues [2].
>> Fix the issue by doing a comprehensive check of all endpoints
>> taking into account difference between high- and full-speed
>> configuration.
>> This patch has not been tested on real hardware.
>
> Oh, I've tested the original patch on real hardware ;). You can remove that line.

BTW I can remove that line, no need to resend because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches