linux-kernel - Re: [PATCH net-next 2/2] net: dsa: Remove adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 26 Apr 2024 13:20:59 +0800
From: kernel test robot <lkp@...el.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>,
	netdev@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: Remove adjust_link paths

Hi Florian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Florian-Fainelli/net-dsa-Remove-fixed_link_update-member/20240426-025626
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240425185336.2084871-3-florian.fainelli%40broadcom.com
patch subject: [PATCH net-next 2/2] net: dsa: Remove adjust_link paths
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240426/202404261353.mKEFmDUo-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240426/202404261353.mKEFmDUo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404261353.mKEFmDUo-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/dsa/port.c:1600:21: warning: variable 'phydev' set but not used [-Wunused-but-set-variable]
           struct phy_device *phydev = NULL;
                              ^
   1 warning generated.


vim +/phydev +1600 net/dsa/port.c

dd805cf3e80e03 Russell King (Oracle  2023-05-25  1594) 
8ae674964e67eb Florian Fainelli      2019-12-16  1595  static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
77373d49de22e8 Ioana Ciornei         2019-05-28  1596  					   unsigned int mode,
77373d49de22e8 Ioana Ciornei         2019-05-28  1597  					   phy_interface_t interface)
77373d49de22e8 Ioana Ciornei         2019-05-28  1598  {
dd0c9855b41310 Russell King (Oracle  2024-04-10  1599) 	struct dsa_port *dp = dsa_phylink_to_port(config);
0e27921816ad99 Ioana Ciornei         2019-05-28 @1600  	struct phy_device *phydev = NULL;
77373d49de22e8 Ioana Ciornei         2019-05-28  1601  	struct dsa_switch *ds = dp->ds;
77373d49de22e8 Ioana Ciornei         2019-05-28  1602  
57d77986e74287 Vladimir Oltean       2021-10-20  1603  	if (dsa_port_is_user(dp))
6ca80638b90cec Florian Fainelli      2023-10-23  1604  		phydev = dp->user->phydev;
0e27921816ad99 Ioana Ciornei         2019-05-28  1605  
d074ebf637f87c Florian Fainelli      2024-04-25  1606  	if (!ds->ops->phylink_mac_link_down)
77373d49de22e8 Ioana Ciornei         2019-05-28  1607  		return;
77373d49de22e8 Ioana Ciornei         2019-05-28  1608  
77373d49de22e8 Ioana Ciornei         2019-05-28  1609  	ds->ops->phylink_mac_link_down(ds, dp->index, mode, interface);
77373d49de22e8 Ioana Ciornei         2019-05-28  1610  }
77373d49de22e8 Ioana Ciornei         2019-05-28  1611  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki