linux-kernel - Re: [PATCH v3 03/14] dt-bindings: fsi: Document the FSI2PIB engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f822b56-8e6a-43e4-afb0-15c964f9474e@kernel.org>
Date: Fri, 26 Apr 2024 08:18:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Eddie James <eajames@...ux.ibm.com>, linux-aspeed@...ts.ozlabs.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-fsi@...ts.ozlabs.org, linux-spi@...r.kernel.org,
 linux-i2c@...r.kernel.org, lakshmiy@...ibm.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, joel@....id.au,
 andrew@...econstruct.com.au
Subject: Re: [PATCH v3 03/14] dt-bindings: fsi: Document the FSI2PIB engine

On 25/04/2024 23:36, Eddie James wrote:
> The FSI2PIB or SCOM engine provides an interface to the POWER processor
> PIB (Pervasive Interconnect Bus).
> 
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> ---
>  .../devicetree/bindings/fsi/ibm,fsi2pib.yaml  | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fsi/ibm,fsi2pib.yaml
> 
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,fsi2pib.yaml b/Documentation/devicetree/bindings/fsi/ibm,fsi2pib.yaml
> new file mode 100644
> index 000000000000..4d557150c2e3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,fsi2pib.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fsi/ibm,fsi2pib.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IBM FSI-attached SCOM engine
> +
> +maintainers:
> +  - Eddie James <eajames@...ux.ibm.com>
> +
> +description:
> +  The SCOM engine is an interface to the POWER processor PIB (Pervasive
> +  Interconnect Bus). This node will always be a child of an FSI CFAM node;
> +  see fsi.txt for details on FSI slave and CFAM nodes.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ibm,fsi2pib
> +      - ibm,i2cr-scom

Sometimes you call these p9, sometimes p10... what is the system or SoC
here? Aren't you adding some generic compatibles? writing-bindings and
numerous guides are clear on that.

Best regards,
Krzysztof