[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240426061940.un6ezs3k4mdcalax@ninjato>
Date: Fri, 26 Apr 2024 08:19:40 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: Claudiu Beznea <claudiu.beznea@...on.dev>, linux-mmc@...r.kernel.org,
linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
Hien Huynh <hien.huynh.px@...esas.com>
Subject: Re: [PATCH v2] mmc: renesas_sdhi: Set the SDBUF after reset
On Fri, Apr 26, 2024 at 07:08:10AM +0200, Ulf Hansson wrote:
> On Wed, 10 Apr 2024 at 15:54, Claudiu Beznea <claudiu.beznea@...on.dev> wrote:
> >
> > For development purpose, renesas_sdhi_probe() could be called w/
> > dma_ops = NULL to force the usage of PIO mode. In this case the
> > renesas_sdhi_enable_dma() will not be called before transferring data.
> >
> > If renesas_sdhi_enable_dma() is not called, renesas_sdhi_clk_enable()
> > call from renesas_sdhi_probe() will configure SDBUF by calling the
> > renesas_sdhi_sdbuf_width() function, but then SDBUF will be reset in
> > tmio_mmc_host_probe() when calling tmio_mmc_reset() though host->reset().
> > If SDBUF is zero the data transfer will not work in PIO mode for RZ/G3S.
> >
> > To fix this call again the renesas_sdhi_sdbuf_width(host, 16) in
> > renesas_sdhi_reset(). The call of renesas_sdhi_sdbuf_width() was not
> > removed from renesas_sdhi_clk_enable() as the host->reset() is optional.
> >
> > Co-developed-by: Hien Huynh <hien.huynh.px@...esas.com>
> > Signed-off-by: Hien Huynh <hien.huynh.px@...esas.com>
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> Wolfram, when you have the time, can we get your opinion on this one?
Sure, I'll try to squeeze it in today. Thanks for the heads up!
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists