linux-kernel - Re: [PATCH] Bluetooth: L2CAP: Fix slab-use-after-free in l2cap_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 26 Apr 2024 10:25:56 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Sungwoo Kim <iam@...g-woo.kim>, linux-bluetooth@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, "Dave (Jing) Tian"
 <daveti@...due.edu>, Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Marcel Holtmann <marcel@...tmann.org>
Subject: Re: [PATCH] Bluetooth: L2CAP: Fix slab-use-after-free in
 l2cap_send_cmd

I prefer that you would put recipient specifications also into the message field “To”
(besides “Cc”).

> Hello, could you review a bug and its fix?

I suggest to omit such a question from better change descriptions.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n45

…
> To fix this, this patch holds and locks the l2cap channel.

Please choose a corresponding imperative wording.

You would probably like to improve your patch approach further
so that provided data will be kept consistent.
https://lore.kernel.org/lkml/20240426073142.363876-1-iam@sung-woo.kim/

Regards,
Markus