[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240426-zupfen-jahrzehnt-5be786bcdf04@brauner>
Date: Fri, 26 Apr 2024 10:31:16 +0200
From: Christian Brauner <brauner@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: viro@...iv.linux.org.uk, mingo@...hat.com, peterz@...radead.org,
juri.lelli@...hat.com, vincent.guittot@...aro.org, jack@...e.cz,
dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
bristot@...hat.com, vschneid@...hat.com, cmllamas@...gle.com,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, ke.wang@...soc.com,
jing.xia@...soc.com, xuewen.yan94@...il.com, Xuewen Yan <xuewen.yan@...soc.com>
Subject: Re: [RFC PATCH] epoll: Add synchronous wakeup support for
ep_poll_callback
adding Eric
On Fri, Apr 26, 2024 at 04:05:48PM +0800, Xuewen Yan wrote:
> Now, the epoll only use wake_up() interface to wake up task.
> However, sometimes, there are epoll users which want to use
> the synchronous wakeup flag to hint the scheduler, such as
> Android binder driver.
> So add a wake_up_sync() define, and use the wake_up_sync()
> when the sync is true in ep_poll_callback().
>
> Co-developed-by: Jing Xia <jing.xia@...soc.com>
> Signed-off-by: Jing Xia <jing.xia@...soc.com>
> Signed-off-by: Xuewen Yan <xuewen.yan@...soc.com>
> ---
> fs/eventpoll.c | 5 ++++-
> include/linux/wait.h | 1 +
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index 882b89edc52a..9b815e0a1ac5 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -1336,7 +1336,10 @@ static int ep_poll_callback(wait_queue_entry_t *wait, unsigned mode, int sync, v
> break;
> }
> }
> - wake_up(&ep->wq);
> + if (sync)
> + wake_up_sync(&ep->wq);
> + else
> + wake_up(&ep->wq);
> }
> if (waitqueue_active(&ep->poll_wait))
> pwake++;
> diff --git a/include/linux/wait.h b/include/linux/wait.h
> index 8aa3372f21a0..2b322a9b88a2 100644
> --- a/include/linux/wait.h
> +++ b/include/linux/wait.h
> @@ -221,6 +221,7 @@ void __wake_up_pollfree(struct wait_queue_head *wq_head);
> #define wake_up_all(x) __wake_up(x, TASK_NORMAL, 0, NULL)
> #define wake_up_locked(x) __wake_up_locked((x), TASK_NORMAL, 1)
> #define wake_up_all_locked(x) __wake_up_locked((x), TASK_NORMAL, 0)
> +#define wake_up_sync(x) __wake_up_sync(x, TASK_NORMAL)
>
> #define wake_up_interruptible(x) __wake_up(x, TASK_INTERRUPTIBLE, 1, NULL)
> #define wake_up_interruptible_nr(x, nr) __wake_up(x, TASK_INTERRUPTIBLE, nr, NULL)
> --
> 2.25.1
>
Powered by blists - more mailing lists