[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <566817ae-90f0-4ec9-b54e-b9fdb635119e@redhat.com>
Date: Fri, 26 Apr 2024 19:23:19 +1000
From: Gavin Shan <gshan@...hat.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>,
linux-pm@...r.kernel.org, loongarch@...ts.linux.dev,
linux-acpi@...r.kernel.org, linux-arch@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kvmarm@...ts.linux.dev, x86@...nel.org, Russell King
<linux@...linux.org.uk>, "Rafael J . Wysocki" <rafael@...nel.org>,
Miguel Luis <miguel.luis@...cle.com>, James Morse <james.morse@....com>,
Salil Mehta <salil.mehta@...wei.com>,
Jean-Philippe Brucker <jean-philippe@...aro.org>,
Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, linuxarm@...wei.com,
justin.he@....com, jianyong.wu@....com
Subject: Re: [PATCH v7 01/16] ACPI: processor: Simplify initial onlining to
use same path for cold and hotplug
On 4/18/24 23:53, Jonathan Cameron wrote:
> Separate code paths, combined with a flag set in acpi_processor.c to
> indicate a struct acpi_processor was for a hotplugged CPU ensured that
> per CPU data was only set up the first time that a CPU was initialized.
> This appears to be unnecessary as the paths can be combined by letting
> the online logic also handle any CPUs online at the time of driver load.
>
> Motivation for this change, beyond simplification, is that ARM64
> virtual CPU HP uses the same code paths for hotplug and cold path in
> acpi_processor.c so had no easy way to set the flag for hotplug only.
> Removing this necessity will enable ARM64 vCPU HP to reuse the existing
> code paths.
>
> Leave noisy pr_info() in place but update it to not state the CPU
> was hotplugged.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>
> ---
> v7: No change.
> v6: New patch.
> RFT: I have very limited test resources for x86 and other
> architectures that may be affected by this change.
> ---
> drivers/acpi/acpi_processor.c | 1 -
> drivers/acpi/processor_driver.c | 44 ++++++++++-----------------------
> include/acpi/processor.h | 2 +-
> 3 files changed, 14 insertions(+), 33 deletions(-)
>
Reviewed-by: Gavin Shan <gshan@...hat.com>
Powered by blists - more mailing lists