[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK1f24=k0mq_PKKWG9KF4vbfk1xN9MrRoa5=DW-eT1YD-S5Vtg@mail.gmail.com>
Date: Fri, 26 Apr 2024 17:33:41 +0800
From: Lance Yang <ioworker0@...il.com>
To: David Hildenbrand <david@...hat.com>
Cc: Zi Yan <ziy@...dia.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
"Matthew Wilcox (Oracle)" <willy@...radead.org>, Yang Shi <shy828301@...il.com>,
Ryan Roberts <ryan.roberts@....com>, Barry Song <21cnbao@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] mm/rmap: do not add fully unmapped large folio to
deferred split list
On Fri, Apr 26, 2024 at 4:26 PM David Hildenbrand <david@...hat.com> wrote:
>
>
> > @@ -1553,9 +1557,9 @@ static __always_inline void __folio_remove_rmap(struct folio *folio,
> > * page of the folio is unmapped and at least one page
> > * is still mapped.
> > */
> > - if (folio_test_large(folio) && folio_test_anon(folio))
> > - if (level == RMAP_LEVEL_PTE || nr < nr_pmdmapped)
> > - deferred_split_folio(folio);
> > + if (folio_test_large(folio) && folio_test_anon(folio) &&
> > + list_empty(&folio->_deferred_list) && partially_mapped)
> > + deferred_split_folio(folio);
>
> And now I realize that we can then even drop the folio_test_large(folio)
> check here!
+1
Thanks,
Lance
>
> --
> Cheers,
>
> David / dhildenb
>
Powered by blists - more mailing lists