[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6b05026f14b6b1e1067876f3bc1c07266dfe2ac2.camel@kernel.org>
Date: Fri, 26 Apr 2024 08:26:28 -0400
From: Jeffrey Layton <jlayton@...nel.org>
To: j.granados@...sung.com, "David S. Miller" <davem@...emloft.net>, Eric
Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
Abeni <pabeni@...hat.com>, Alexander Aring <alex.aring@...il.com>, Stefan
Schmidt <stefan@...enfreihafen.org>, Miquel Raynal
<miquel.raynal@...tlin.com>, David Ahern <dsahern@...nel.org>, Steffen
Klassert <steffen.klassert@...unet.com>, Herbert Xu
<herbert@...dor.apana.org.au>, Matthieu Baerts <matttbe@...nel.org>, Mat
Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>, Ralf
Baechle <ralf@...ux-mips.org>, Remi Denis-Courmont <courmisch@...il.com>,
Allison Henderson <allison.henderson@...cle.com>, David Howells
<dhowells@...hat.com>, Marc Dionne <marc.dionne@...istor.com>, Marcelo
Ricardo Leitner <marcelo.leitner@...il.com>, Xin Long
<lucien.xin@...il.com>, Wenjia Zhang <wenjia@...ux.ibm.com>, Jan Karcher
<jaka@...ux.ibm.com>, "D. Wythe" <alibuda@...ux.alibaba.com>, Tony Lu
<tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>, Trond
Myklebust <trond.myklebust@...merspace.com>, Anna Schumaker
<anna@...nel.org>, Chuck Lever <chuck.lever@...cle.com>, Neil Brown
<neilb@...e.de>, Olga Kornievskaia <kolga@...app.com>, Dai Ngo
<Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>, Jon Maloy
<jmaloy@...hat.com>, Ying Xue <ying.xue@...driver.com>, Martin Schiller
<ms@....tdt.de>, Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik
<kadlec@...filter.org>, Florian Westphal <fw@...len.de>, Roopa Prabhu
<roopa@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>, Simon
Horman <horms@...ge.net.au>, Julian Anastasov <ja@....bg>, Joerg Reuter
<jreuter@...na.de>, Luis Chamberlain <mcgrof@...nel.org>, Kees Cook
<keescook@...omium.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
dccp@...r.kernel.org, linux-wpan@...r.kernel.org, mptcp@...ts.linux.dev,
linux-hams@...r.kernel.org, linux-rdma@...r.kernel.org,
rds-devel@....oracle.com, linux-afs@...ts.infradead.org,
linux-sctp@...r.kernel.org, linux-s390@...r.kernel.org,
linux-nfs@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
linux-x25@...r.kernel.org, netfilter-devel@...r.kernel.org,
coreteam@...filter.org, bridge@...ts.linux.dev, lvs-devel@...r.kernel.org
Subject: Re: [PATCH v5 4/8] net: sunrpc: Remove the now superfluous sentinel
elements from ctl_table array
On Fri, 2024-04-26 at 12:46 +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@...sung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
>
> * Remove sentinel element from ctl_table structs.
>
> Signed-off-by: Joel Granados <j.granados@...sung.com>
> ---
> net/sunrpc/sysctl.c | 1 -
> net/sunrpc/xprtrdma/svc_rdma.c | 1 -
> net/sunrpc/xprtrdma/transport.c | 1 -
> net/sunrpc/xprtsock.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c
> index 93941ab12549..5f3170a1c9bb 100644
> --- a/net/sunrpc/sysctl.c
> +++ b/net/sunrpc/sysctl.c
> @@ -160,7 +160,6 @@ static struct ctl_table debug_table[] = {
> .mode = 0444,
> .proc_handler = proc_do_xprt,
> },
> - { }
> };
>
> void
> diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c
> index f86970733eb0..474f7a98fe9e 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma.c
> @@ -209,7 +209,6 @@ static struct ctl_table svcrdma_parm_table[] = {
> .extra1 = &zero,
> .extra2 = &zero,
> },
> - { },
> };
>
> static void svc_rdma_proc_cleanup(void)
> diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
> index 29b0562d62e7..9a8ce5df83ca 100644
> --- a/net/sunrpc/xprtrdma/transport.c
> +++ b/net/sunrpc/xprtrdma/transport.c
> @@ -137,7 +137,6 @@ static struct ctl_table xr_tunables_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec,
> },
> - { },
> };
>
> #endif
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index bb9b747d58a1..f62f7b65455b 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -160,7 +160,6 @@ static struct ctl_table xs_tunables_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec_jiffies,
> },
> - { },
> };
>
> /*
>
Reviewed-by: Jeffrey Layton <jlayton@...nel.org>
Powered by blists - more mailing lists