linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b87b00f-9fc2-47b2-9e81-4a391458f031@phytec.de>
Date: Fri, 26 Apr 2024 14:54:33 +0200
From: Wadim Egorov <w.egorov@...tec.de>
To: Garrett Giordano <ggiordano@...tec.com>, <nm@...com>, <vigneshr@...com>,
	<kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <upstream@...ts.phytec.de>
Subject: Re: [PATCH] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add USB-C

Hi Garrett,

thanks for sending!

It seems like this patch completes the board's support. Every 
interface/component is now fully supported.

Am 25.04.24 um 17:25 schrieb Garrett Giordano:
> The USB-C PD manages plug orientation, power delivery, and our endpoint
> for the USB interface. Add this node and include its endpoint.
> 
> Configure USB0 for role-switching and wire it to our USB-C PD endpoint.
> 
> Signed-off-by: Garrett Giordano <ggiordano@...tec.com>

Reviewed-by: Wadim Egorov <w.egorov@...tec.de>

> ---
>   .../dts/ti/k3-am625-phyboard-lyra-rdk.dts     | 26 ++++++++++++++++++-
>   1 file changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> index dfc78995d30a..fb3bc914a018 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> @@ -348,6 +348,24 @@ gpio_exp: gpio-expander@21 {
>   				  "GPIO6_ETH1_USER_RESET", "GPIO7_AUDIO_USER_RESET";
>   	};
>   
> +	usb-pd@22 {
> +		compatible = "ti,tps6598x";
> +		reg = <0x22>;
> +
> +		connector {
> +			compatible = "usb-c-connector";
> +			label = "USB-C";
> +			self-powered;
> +			data-role = "dual";
> +			power-role = "sink";
> +			port {
> +				usb_con_hs: endpoint {
> +					remote-endpoint = <&typec_hs>;
> +				};
> +			};
> +		};
> +	};
> +
>   	sii9022: bridge-hdmi@39 {
>   		compatible = "sil,sii9022";
>   		reg = <0x39>;
> @@ -449,7 +467,13 @@ &usbss1 {
>   };
>   
>   &usb0 {
> -	dr_mode = "peripheral";
> +	usb-role-switch;
> +
> +	port {
> +		typec_hs: endpoint {
> +			remote-endpoint = <&usb_con_hs>;
> +		};
> +	};
>   };
>   
>   &usb1 {