linux-kernel - Re:Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e6966e0.a07e.18f1a7f7863.Coremail.lumingyindetect@126.com>
Date: Fri, 26 Apr 2024 21:01:52 +0800 (CST)
From: lumingyindetect <lumingyindetect@....com>
To: "Markus Elfring" <Markus.Elfring@....de>
Cc: linux-serial@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>, 
	"Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>, 
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	"Jiri Slaby" <jirislaby@...nel.org>
Subject: Re:Re: [PATCH] serial: 8250_lpss: Fix memory leak in
 lpss8250_probe()

Dear Markus,<br/><br/>Thank you for your patient guidance and advice! This is my first time submitting a patch, and I haven't fully understood the meaning of "add a commit subject for this tag" yet. Could you please provide some examples or guidance on how to add it? I appreciate your help!<br/><br/>Best regards,<br/>LuMingYin
At 2024-04-26 20:28:43, "Markus Elfring" <Markus.Elfring@....de> wrote:
>…
>> In the lpss8250_probe() function, I added a label named "free_irq_vectors" to release the dynamically allocated memory region pointed to by the variable pdev, and replaced the two return statements mentioned above with goto statements to this label.
>
>* Please improve the word wrapping according to line length preferences
>  for change descriptions.
>
>* Please choose corresponding imperative wordings.
>
>
>> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
>
>Please add a commit subject for this tag.
>
>
>> Signed-off-by: LuMingYin <11570291+yin-luming@...r.noreply.gitee.com>
>
>I find the author email addresses suspicious according to the Developer's Certificate of Origin.
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n398
>
>Would other email addresses be more appropriate for desired patch communication?
>
>Regards,
>Markus