linux-kernel - Re: [PATCH] io_uring/msg_ring: reuse ctx->submitter_task read using READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171413885012.211722.950447967094465539.b4-ty@kernel.dk>
Date: Fri, 26 Apr 2024 07:40:50 -0600
From: Jens Axboe <axboe@...nel.dk>
To: linke li <lilinke99@...com>
Cc: xujianhao01@...il.com, Pavel Begunkov <asml.silence@...il.com>, 
 io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] io_uring/msg_ring: reuse ctx->submitter_task read
 using READ_ONCE instead of re-reading it


On Fri, 26 Apr 2024 11:24:37 +0800, linke li wrote:
> In io_msg_exec_remote(), ctx->submitter_task is read using READ_ONCE at
> the beginning of the function, checked, and then re-read from
> ctx->submitter_task, voiding all guarantees of the checks. Reuse the value
> that was read by READ_ONCE to ensure the consistency of the task struct
> throughout the function.
> 
> 
> [...]

Applied, thanks!

[1/1] io_uring/msg_ring: reuse ctx->submitter_task read using READ_ONCE instead of re-reading it
      commit: a4d416dc60980f741f0bfa1f34a1059c498c1b4e

Best regards,
-- 
Jens Axboe