linux-kernel - Re: [PATCH v2 00/11] Series to deliver Ethernets for STM32MP13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171414068246.1496656.8837914641064924461.robh@kernel.org>
Date: Fri, 26 Apr 2024 09:22:41 -0500
From: Rob Herring <robh@...nel.org>
To: Christophe Roullier <christophe.roullier@...s.st.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, 
 linux-arm-kernel@...ts.infradead.org, Mark Brown <broonie@...nel.org>, 
 Jose Abreu <joabreu@...opsys.com>, Jakub Kicinski <kuba@...nel.org>, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, Marek Vasut <marex@...x.de>, 
 Paolo Abeni <pabeni@...hat.com>, Conor Dooley <conor+dt@...nel.org>, 
 devicetree@...r.kernel.org, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
 netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
 Liam Girdwood <lgirdwood@...il.com>, Eric Dumazet <edumazet@...gle.com>, 
 Richard Cochran <richardcochran@...il.com>, 
 "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 00/11] Series to deliver Ethernets for STM32MP13

On Fri, 26 Apr 2024 14:56:56 +0200, Christophe Roullier wrote:
> STM32MP13 is STM32 SOC with 2 GMACs instances
> This board have 2 RMII phy:
>   -Ethernet1: RMII with crystal
>   -Ethernet2: RMII without crystal
> Rework dwmac glue to simplify management for next stm32
> Add support for PHY regulator
> 
> V2: - Remark from Rob Herring (add Krzysztof's ack in patch 02/11, update in yaml)
>       Remark from Serge Semin (upate commits msg)
> 
> Christophe Roullier (11):
>   dt-bindings: net: add STM32MP13 compatible in documentation for stm32
>   dt-bindings: net: add phy-supply property for stm32
>   net: stmmac: dwmac-stm32: rework glue to simplify management
>   net: stmmac: dwmac-stm32: add management of stm32mp13
>   net: stmmac: dwmac-stm32: update config management for phy wo cristal
>   net: stmmac: dwmac-stm32: clean the way to manage wol irqwake
>   net: stmmac: dwmac-stm32: support the phy-supply regulator binding
>   ARM: dts: stm32: add ethernet1 and ethernet2 support on stm32mp13
>   ARM: dts: stm32: add ethernet1/2 RMII pins for STM32MP13F-DK board
>   ARM: dts: stm32: add ethernet1 and ethernet2 for STM32MP135F-DK board
>   ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support
> 
>  .../devicetree/bindings/net/stm32-dwmac.yaml  |  79 +++++-
>  arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi   |  71 ++++++
>  arch/arm/boot/dts/st/stm32mp131.dtsi          |  31 +++
>  arch/arm/boot/dts/st/stm32mp133.dtsi          |  30 +++
>  arch/arm/boot/dts/st/stm32mp135f-dk.dts       |  48 ++++
>  arch/arm/configs/multi_v7_defconfig           |   1 +
>  .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 235 ++++++++++++------
>  7 files changed, 416 insertions(+), 79 deletions(-)
> 
> --
> 2.25.1
> 
> 
> 

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y st/stm32mp135f-dk.dtb' for 20240426125707.585269-1-christophe.roullier@...s.st.com:

arch/arm/boot/dts/st/stm32mp135f-dk.dtb: ethernet@...0e000: Unevaluated properties are not allowed ('st,ext-phyclk' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/stm32-dwmac.yaml#