linux-kernel - Re: [PATCH] "drivers:Fixed memory leak in /linux/drivers/tty/serial/8250/8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ziu7hC25v2Xi50VG@smile.fi.intel.com>
Date: Fri, 26 Apr 2024 17:34:44 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: lumingyindetect@....com
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	ilpo.jarvinen@...ux.intel.com, gregkh@...uxfoundation.org,
	jirislaby@...nel.org,
	LuMingYin <11570291+yin-luming@...r.noreply.gitee.com>
Subject: Re: [PATCH] "drivers:Fixed memory leak in
 /linux/drivers/tty/serial/8250/8250_lpss.c file.

On Fri, Apr 26, 2024 at 03:19:39AM +0100, lumingyindetect@....com wrote:
> From: LuMingYin <11570291+yin-luming@...r.noreply.gitee.com>
> 
> In the lpss8250_probe function in the file
> /linux/drivers/tty/serial/8250/8250_lpss.c, there were certain return paths
> where pci_free_irq_vectors was not called to release memory related to pdev,
> leading to a memory leak. This commit fixes that issue."

This patch does not fix anything. The driver uses pcim_enable_device()
which changes how this all behaves.

NAK.

-- 
With Best Regards,
Andy Shevchenko