linux-kernel - Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ziu-HUUE43xsjnia@smile.fi.intel.com>
Date: Fri, 26 Apr 2024 17:45:49 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: lumingyindetect@....com, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, ilpo.jarvinen@...ux.intel.com,
	gregkh@...uxfoundation.org, jirislaby@...nel.org,
	LuMingYin <11570291+yin-luming@...r.noreply.gitee.com>
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

On Fri, Apr 26, 2024 at 04:53:18PM +0300, Dan Carpenter wrote:

> > Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
> 
> This is the wrong hash and the format is wrong.  It should be:
> 
> Fixes: 254cc7743e84 ("serial: 8250_lpss: Switch over to MSI interrupts")

Since you are here, just pay attention that this does NOT fix anything
as it uses pcim_enable_device(). I hope smatch won't stumble over this
and produce false positives.

-- 
With Best Regards,
Andy Shevchenko