[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87jzkktaui.wl-maz@kernel.org>
Date: Fri, 26 Apr 2024 16:14:29 +0100
From: Marc Zyngier <maz@...nel.org>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Peter Zijlstra
<peterz@...radead.org>,
<linux-pm@...r.kernel.org>,
<loongarch@...ts.linux.dev>,
<linux-acpi@...r.kernel.org>,
<linux-arch@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<kvmarm@...ts.linux.dev>,
<x86@...nel.org>,
Russell King <linux@...linux.org.uk>,
"Rafael J . Wysocki"
<rafael@...nel.org>,
Miguel Luis <miguel.luis@...cle.com>,
James Morse
<james.morse@....com>,
Salil Mehta <salil.mehta@...wei.com>,
Jean-Philippe
Brucker <jean-philippe@...aro.org>,
Catalin Marinas
<catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Hanjun Guo <guohanjun@...wei.com>,
Ingo Molnar <mingo@...hat.com>,
Borislav Petkov <bp@...en8.de>,
Dave
Hansen <dave.hansen@...ux.intel.com>,
<linuxarm@...wei.com>,
<justin.he@....com>,
<jianyong.wu@....com>,
Lorenzo Pieralisi
<lpieralisi@...nel.org>,
Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v8 10/16] irqchip/gic-v3: Don't return errors from gic_acpi_match_gicc()
On Fri, 26 Apr 2024 14:51:20 +0100,
Jonathan Cameron <Jonathan.Cameron@...wei.com> wrote:
>
> From: James Morse <james.morse@....com>
>
> gic_acpi_match_gicc() is only called via gic_acpi_count_gicr_regions().
> It should only count the number of enabled redistributors, but it
> also tries to sanity check the GICC entry, currently returning an
> error if the Enabled bit is set, but the gicr_base_address is zero.
>
> Adding support for the online-capable bit to the sanity check will
> complicate it, for no benefit. The existing check implicitly depends on
> gic_acpi_count_gicr_regions() previous failing to find any GICR regions
> (as it is valid to have gicr_base_address of zero if the redistributors
> are described via a GICR entry).
>
> Instead of complicating the check, remove it. Failures that happen at
> this point cause the irqchip not to register, meaning no irqs can be
> requested. The kernel grinds to a panic() pretty quickly.
>
> Without the check, MADT tables that exhibit this problem are still
> caught by gic_populate_rdist(), which helpfully also prints what went
> wrong:
> | CPU4: mpidr 100 has no re-distributor!
>
> Signed-off-by: James Morse <james.morse@....com>
> Reviewed-by: Gavin Shan <gshan@...hat.com>
> Tested-by: Miguel Luis <miguel.luis@...cle.com>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Reviewed-by: Marc Zyngier <maz@...nel.org>
M.
--
Without deviation from the norm, progress is not possible.
Powered by blists - more mailing lists