linux-kernel - Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <047e490b-0dbf-49b7-9506-996f0053e92d@moroto.mountain>
Date: Fri, 26 Apr 2024 18:32:33 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: lumingyindetect@....com, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, ilpo.jarvinen@...ux.intel.com,
	gregkh@...uxfoundation.org, jirislaby@...nel.org,
	LuMingYin <11570291+yin-luming@...r.noreply.gitee.com>
Subject: Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()

On Fri, Apr 26, 2024 at 05:45:49PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 26, 2024 at 04:53:18PM +0300, Dan Carpenter wrote:
> 
> > > Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
> > 
> > This is the wrong hash and the format is wrong.  It should be:
> > 
> > Fixes: 254cc7743e84 ("serial: 8250_lpss: Switch over to MSI interrupts")
> 
> Since you are here, just pay attention that this does NOT fix anything
> as it uses pcim_enable_device(). I hope smatch won't stumble over this
> and produce false positives.
> 

Ah...  No, this isn't a Smatch warning.  I think I tried to add it but
was told it was wrong because I have this in my unpublished code.  :P

// Are these affected by pcim_enable_device()?
//      { "pci_alloc_irq_vectors", ALLOC, 0, "$",  &int_one, &int_max },
//      { "pci_free_irq_vectors", RELEASE, 0, "$" },

So when we're using pcim_enable_device(), calling pci_free_irq_vectors()
is harmless but not necessary?

regards,
dan carpenter