linux-kernel - Re: [PATCH 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with nvkm_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 26 Apr 2024 15:47:25 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"lyude@...hat.com" <lyude@...hat.com>
CC: "bskeggs@...hat.com" <bskeggs@...hat.com>, "kherbst@...hat.com"
	<kherbst@...hat.com>, "airlied@...hat.com" <airlied@...hat.com>,
	"justinstitt@...gle.com" <justinstitt@...gle.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"keescook@...omium.org" <keescook@...omium.org>, "airlied@...il.com"
	<airlied@...il.com>, "dakr@...hat.com" <dakr@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"daniel@...ll.ch" <daniel@...ll.ch>
Subject: Re: [PATCH 1/2] drm/nouveau/firmware: Fix SG_DEBUG error with
 nvkm_firmware_ctor()

On Fri, 2024-04-26 at 11:41 -0400, Lyude Paul wrote:
> We hit this because when initializing firmware of type
> NVKM_FIRMWARE_IMG_DMA we allocate coherent memory and then attempt to
> include that coherent memory in a scatterlist. 

I'm sure this patch is a good one, and I will try to test it soon, but I am
very curious to know why including coherent memory in a scatterlist is bad.