linux-kernel - [PATCH 1/2] rapidio: specify the type for tristate choice explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240427104231.2728905-2-masahiroy@kernel.org>
Date: Sat, 27 Apr 2024 19:42:30 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
	Matt Porter <mporter@...nel.crashing.org>,
	Alexandre Bounine <alex.bou9@...il.com>,
	Masahiro Yamada <masahiroy@...nel.org>
Subject: [PATCH 1/2] rapidio: specify the type for tristate choice explicitly

If the type of choice is not specified, it is implied by the first
entry within the choice block.

In this case, the first (and only) entry, RAPIDIO_ENUM_BASIC, is
tristate, hence this choice behaves as tristate.

Kconfig will stop this implication because it has a bug, and 99% of
choice use cases are bool. In fact, this is the only instance of
tristate choice in the kernel.

Before transitioning the default choice type to 'bool', specify the
type explicitly for this case.

Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
---

 drivers/rapidio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig
index b9f8514909bf..72b5b02492a1 100644
--- a/drivers/rapidio/Kconfig
+++ b/drivers/rapidio/Kconfig
@@ -60,7 +60,7 @@ config RAPIDIO_DEBUG
 	  If you are unsure about this, say N here.

 choice
-	prompt "Enumeration method"
+	tristate "Enumeration method"
 	depends on RAPIDIO
 	default RAPIDIO_ENUM_BASIC
 	help
-- 
2.40.1