linux-kernel - Re: [PATCH] cpufreq: amd-pstate: fix code format problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 27 Apr 2024 09:30:22 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Perry Yuan <perry.yuan@....com>, rafael.j.wysocki@...el.com,
 viresh.kumar@...aro.org, gautham.shenoy@....com, Borislav.Petkov@....com,
 Ray.Huang@....com, Alexander.Deucher@....com
Cc: Xinmei.Huang@....com, oleksandr@...alenko.name, Xiaojian.Du@....com,
 Li.Meng@....com, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: amd-pstate: fix code format problems

On 4/27/2024 08:52, Perry Yuan wrote:
> get some code format problems fixed in the amd-pstate driver.
> 
> Changes Made:
> 
> - Fixed incorrect comment format in the functions.
> 
> - Removed unnecessary blank line.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404271148.HK9yHBlB-lkp@intel.com/
> Signed-off-by: Perry Yuan <perry.yuan@....com>
> ---

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

>   drivers/cpufreq/amd-pstate.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 83a29b257794..85656342a101 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -792,7 +792,7 @@ static void amd_pstate_update_limits(unsigned int cpu)
>   	mutex_unlock(&amd_pstate_driver_lock);
>   }
>   
> -/**
> +/*
>    * Get pstate transition delay time from ACPI tables that firmware set
>    * instead of using hardcode value directly.
>    */
> @@ -807,7 +807,7 @@ static u32 amd_pstate_get_transition_delay_us(unsigned int cpu)
>   	return transition_delay_ns / NSEC_PER_USEC;
>   }
>   
> -/**
> +/*
>    * Get pstate transition latency value from ACPI tables that firmware
>    * set instead of using hardcode value directly.
>    */
> @@ -822,7 +822,7 @@ static u32 amd_pstate_get_transition_latency(unsigned int cpu)
>   	return transition_latency;
>   }
>   
> -/**
> +/*
>    * amd_pstate_init_freq: Initialize the max_freq, min_freq,
>    *                       nominal_freq and lowest_nonlinear_freq for
>    *                       the @cpudata object.
> @@ -843,7 +843,6 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
>   	u32 boost_ratio, lowest_nonlinear_ratio;
>   	struct cppc_perf_caps cppc_perf;
>   
> -
>   	ret = cppc_get_perf_caps(cpudata->cpu, &cppc_perf);
>   	if (ret)
>   		return ret;