linux-kernel - [PATCH v2 5/8] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240426165839.v2.5.I9982cd5d8014de7a4513f5619f66f88da49ce4ec@changeid>
Date: Fri, 26 Apr 2024 16:58:38 -0700
From: Douglas Anderson <dianders@...omium.org>
To: dri-devel@...ts.freedesktop.org
Cc: Linus Walleij <linus.walleij@...aro.org>,
	lvzhaoxiong@...qin.corp-partner.google.com,
	Jani Nikula <jani.nikula@...ux.intel.com>,
	Hsin-Yi Wang <hsinyi@...gle.com>,
	Javier Martinez Canillas <javierm@...hat.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Joel Selvaraj <jo@...amily.in>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Cong Yang <yangcong5@...qin.corp-partner.google.com>,
	Sam Ravnborg <sam@...nborg.org>,
	Douglas Anderson <dianders@...omium.org>,
	Daniel Vetter <daniel@...ll.ch>,
	David Airlie <airlied@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2 5/8] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints

We really don't expect these errors to be printed over and over
again. When a driver hits the error it should bail out. Just use a
normal error print.

Signed-off-by: Douglas Anderson <dianders@...omium.org>
---

Changes in v2:
- New

 drivers/gpu/drm/drm_mipi_dsi.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index b7c75a4396e6..8bc2db971e93 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -770,7 +770,7 @@ EXPORT_SYMBOL(mipi_dsi_generic_write);
  * @payload: buffer containing the payload
  * @size: size of payload buffer
  *
- * Like mipi_dsi_generic_write() but includes a dev_err_ratelimited()
+ * Like mipi_dsi_generic_write() but includes a dev_err()
  * call for you and returns 0 upon success, not the number of bytes sent.
  *
  * Return: 0 on success or a negative error code on failure.
@@ -783,8 +783,8 @@ int mipi_dsi_generic_write_chatty(struct mipi_dsi_device *dsi,
 
 	ret = mipi_dsi_generic_write(dsi, payload, size);
 	if (ret < 0) {
-		dev_err_ratelimited(dev, "sending generic data %*ph failed: %d\n",
-				    (int)size, payload, (int)ret);
+		dev_err(dev, "sending generic data %*ph failed: %d\n",
+			(int)size, payload, (int)ret);
 		return ret;
 	}
 
@@ -814,8 +814,8 @@ void mipi_dsi_generic_write_multi(struct mipi_dsi_multi_context *ctx,
 	ret = mipi_dsi_generic_write(dsi, payload, size);
 	if (ret < 0) {
 		ctx->accum_err = ret;
-		dev_err_ratelimited(dev, "sending generic data %*ph failed: %d\n",
-				    (int)size, payload, ctx->accum_err);
+		dev_err(dev, "sending generic data %*ph failed: %d\n",
+			(int)size, payload, ctx->accum_err);
 	}
 }
 EXPORT_SYMBOL(mipi_dsi_generic_write_multi);
@@ -914,7 +914,7 @@ EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer);
  * @data: buffer containing data to be transmitted
  * @len: size of transmission buffer
  *
- * Like mipi_dsi_dcs_write_buffer() but includes a dev_err_ratelimited()
+ * Like mipi_dsi_dcs_write_buffer() but includes a dev_err()
  * call for you and returns 0 upon success, not the number of bytes sent.
  *
  * Return: 0 on success or a negative error code on failure.
@@ -927,8 +927,8 @@ int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi,
 
 	ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
 	if (ret < 0) {
-		dev_err_ratelimited(dev, "sending dcs data %*ph failed: %d\n",
-				    (int)len, data, (int)ret);
+		dev_err(dev, "sending dcs data %*ph failed: %d\n",
+			(int)len, data, (int)ret);
 		return ret;
 	}
 
@@ -958,8 +958,8 @@ void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx,
 	ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
 	if (ret < 0) {
 		ctx->accum_err = ret;
-		dev_err_ratelimited(dev, "sending dcs data %*ph failed: %d\n",
-				    (int)len, data, ctx->accum_err);
+		dev_err(dev, "sending dcs data %*ph failed: %d\n",
+			(int)len, data, ctx->accum_err);
 	}
 }
 EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer_multi);
-- 
2.44.0.769.g3c40516874-goog