linux-kernel - Re: drm/debugfs: Drop conditionals around of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 28 Apr 2024 16:52:13 +0800
From: Sui Jingfeng <suijingfeng@...c.ac.cn>
To: Sui Jingfeng <sui.jingfeng@...ux.dev>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
Cc: Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Douglas Anderson <dianders@...omium.org>,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Biju Das <biju.das.jz@...renesas.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: drm/debugfs: Drop conditionals around of_node pointers

ping

在 2024/3/22 06:22, Sui Jingfeng 写道:
> Having conditional around the of_node pointer of the drm_bridge structure
> turns out to make driver code use ugly #ifdef blocks. Drop the conditionals
> to simplify debugfs.
> 
> Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers")
> Signed-off-by: Sui Jingfeng <sui.jingfeng@...ux.dev>
> ---
>   drivers/gpu/drm/drm_debugfs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index 08fcefd804bc..28a471fe4bc8 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -597,10 +597,10 @@ static int bridges_show(struct seq_file *m, void *data)
>   		drm_printf(&p, "\ttype: [%d] %s\n",
>   			   bridge->type,
>   			   drm_get_connector_type_name(bridge->type));
> -#ifdef CONFIG_OF
> +
>   		if (bridge->of_node)
>   			drm_printf(&p, "\tOF: %pOFfc\n", bridge->of_node);
> -#endif
> +
>   		drm_printf(&p, "\tops: [0x%x]", bridge->ops);
>   		if (bridge->ops & DRM_BRIDGE_OP_DETECT)
>   			drm_puts(&p, " detect");

-- 
Best regards
Sui Jingfeng