linux-kernel - RE: [PATCH 05/15] i2c: imx-lpi2c: use 'time_left' variable with wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 28 Apr 2024 01:45:12 +0000
From: Peng Fan <peng.fan@....com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
CC: Aisheng Dong <aisheng.dong@....com>, Andi Shyti <andi.shyti@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 05/15] i2c: imx-lpi2c: use 'time_left' variable with
 wait_for_completion_timeout()

> Subject: [PATCH 05/15] i2c: imx-lpi2c: use 'time_left' variable with
> wait_for_completion_timeout()
> 
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_completion_timeout() causing patterns like:
> 
> 	timeout = wait_for_completion_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
> 
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> self explaining.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Reviewed-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/i2c/busses/i2c-imx-lpi2c.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-
> lpi2c.c
> index 36e8f6196a87..0197786892a2 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -307,11 +307,11 @@ static int lpi2c_imx_master_disable(struct
> lpi2c_imx_struct *lpi2c_imx)
> 
>  static int lpi2c_imx_msg_complete(struct lpi2c_imx_struct *lpi2c_imx)  {
> -	unsigned long timeout;
> +	unsigned long time_left;
> 
> -	timeout = wait_for_completion_timeout(&lpi2c_imx->complete, HZ);
> +	time_left = wait_for_completion_timeout(&lpi2c_imx->complete, HZ);
> 
> -	return timeout ? 0 : -ETIMEDOUT;
> +	return time_left ? 0 : -ETIMEDOUT;
>  }
> 
>  static int lpi2c_imx_txfifo_empty(struct lpi2c_imx_struct *lpi2c_imx)
> --
> 2.43.0
>