linux-kernel - Re: [PATCH v3] Input: xen-kbdfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zi2wDivw7XBuNnj-@google.com>
Date: Sat, 27 Apr 2024 19:10:22 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Jason Andryuk <jandryuk@...il.com>
Cc: linux-kernel@...r.kernel.org, Phillip Susi <phill@...susis.net>,
	stable@...r.kernel.org,
	Mattijs Korpershoek <mkorpershoek@...libre.com>,
	linux-input@...r.kernel.org,
	xen-devel <xen-devel@...ts.xenproject.org>,
	Juergen Gross <jgross@...e.com>
Subject: Re: [PATCH v3] Input: xen-kbdfront - drop keys to shrink modalias

Hi Jason,

On Sun, Apr 21, 2024 at 07:57:24PM -0400, Jason Andryuk wrote:
> Hi Dmitry,
> 
> On Thu, Mar 28, 2024 at 2:05 PM Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> >
> > Hi Jason,
> >
> > On Wed, Mar 20, 2024 at 01:42:27PM -0400, Jason Andryuk wrote:
> > > Hi Dmitry,
> > >
> > > Do you have any feedback, or can you pick up this patch?  It solves a
> > > real issue affecting udev, which crashes the Debian installer and
> > > breaks the mouse for Gnome.
> > >
> > > Or would you be okay if this patch went in via the Xen tree?
> >
> > I'd rather not. Could you please ping me in 2 weeks on this. I promise
> > we find a solution before the next release.
> 
> It's been ~3 weeks.  Any ideas?
> 
> If you think this patch should be pursued in this form, I'd like to
> post a v4 that adds BTN_DPAD_{UP,DOWN,LEFT,RIGHT} on the off chance
> someone wants to use a controller.  I dropped them initially since
> they are not keyboard keys, but button presses are delivered through
> the keyboard.  Hence, they should be included.

I do not think suppressing random keys in the driver is a good idea,
because we may fill up what you currently consider as gaps, and
people will be confused why certain events are not being delivered.

I just posted a patch (you are CCed) that attempts to trim too long 
modalias strings, please take a look and see if that solves your issue.

Thanks.

-- 
Dmitry