lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <79127b00-4349-48bd-9023-259c72cc47dd@kernel.org>
Date: Sun, 28 Apr 2024 17:59:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>,
 Peter Griffin <peter.griffin@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, Roy Luo <royluo@...gle.com>,
 kernel-team@...roid.com, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] enable USB on Pixel 6 (Oriole)

On 23/04/2024 22:52, André Draszik wrote:
> These patches enable USB in peripheral mode on Pixel 6.
> 
> We can only support peripheral mode at this stage, as the MAX77759 TCPCI
> controller used on Pixel 6 to do the role selection doesn't have a(n
> upstream) Linux driver. Therefore the role is defaulted to peripheral
> without any endpoints / ports.
> 
> For the same reason, we can not detect the orientation of a SS USB-C cable
> and therefore it will only establish a link in SS mode in one of the
> possible orientations of the cable. In all other cases, the link will be HS.
> 
> This series has a dependency on other patches, please see below.
> 
> I have mainly tested this as CDC ECM Ethernet device using the following:
> 
>     mount -t configfs configfs /sys/kernel/config/
>     modprobe libcomposite
>     modprobe usb_f_ecm
>     mkdir /sys/kernel/config/usb_gadget/g3
>     cd /sys/kernel/config/usb_gadget/g3
> 
>     echo 0xadad > idVendor
>     echo 0xddaa > idProduct
>     mkdir strings/0x409
>     echo 01234567 > strings/0x409/serialnumber
>     echo ADADAD > strings/0x409/manufacturer
>     cat /proc/device-tree/model > strings/0x409/product
>     # create the function (name must match a usb_f_<name> module such as 'acm')
>     mkdir functions/ecm.usb0
>     # stable MAC addresses
>     echo "6e:27:3a:b9:40:87" > functions/ecm.usb0/dev_addr
>     echo "ca:49:84:b0:3b:bc" > functions/ecm.usb0/host_addr
> 
>     mkdir configs/c.1
>     ln -s functions/ecm.usb0 configs/c.1/
>     echo $(ls -1 /sys/class/udc/) > UDC
> 
>     ifconfig usb0 192.168.1.2 up
> 
> at which point the other side should detect it and network communication
> becomes possible (once the other side also configures its network
> interface).
> 
> Due to the clock IDs, this series depends on the bindings patch
> "dt-bindings: clock: google,gs101-clock: add HSI0 clock management unit" of
> the series in
> https://lore.kernel.org/r/20240423-hsi0-gs101-v1-0-2c3ddb50c720@linaro.org
> 

This is weird. The patchset applied cleanly without DTS parts from above
set, but then failed to build. Obviously, because it depends on DTS,
even though it is not explicitly said here...

But when I applied DTS from above, these two patches fail to apply, so I
really wonder how this was organized in the first place. Please rebase.

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ