linux-kernel - Re: [syzbot] [bluetooth?] possible deadlock in hci_dev_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 07:42:40 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+c55f7bc8d4809b2bad59@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [bluetooth?] possible deadlock in hci_dev_do_close (2)

On Sun, 28 Apr 2024 15:35:27 -0700
> syzbot has found a reproducer for the following issue on:
> 
> HEAD commit:    bb7a2467e6be Add linux-next specific files for 20240426
> git tree:       linux-next
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1349ee9b180000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  bb7a2467e6be

--- x/net/bluetooth/hci_sync.c
+++ y/net/bluetooth/hci_sync.c
@@ -306,11 +306,9 @@ static void hci_cmd_sync_work(struct wor
 		if (entry->func) {
 			int err;
 
-			hci_req_sync_lock(hdev);
 			err = entry->func(hdev, entry->data);
 			if (entry->destroy)
 				entry->destroy(hdev, entry->data, err);
-			hci_req_sync_unlock(hdev);
 		}
 
 		kfree(entry);
--