linux-kernel - Re: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NQPgW-xmebV5OS-8v_-vY07hP4NYJemYLOC4iCydkxLw@mail.gmail.com>
Date: Mon, 29 Apr 2024 12:14:11 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: "Zhou, Bob" <Bob.Zhou@....com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, 
	"Deucher, Alexander" <Alexander.Deucher@....com>, "Koenig, Christian" <Christian.Koenig@....com>, 
	"Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	"Kuehling, Felix" <Felix.Kuehling@....com>, "Zhang, Hawking" <Hawking.Zhang@....com>, 
	Guchun Chen <guchun.chen@....com>, "Ma, Le" <Le.Ma@....com>, "Lazar, Lijo" <Lijo.Lazar@....com>, 
	"Sharma, Shashank" <Shashank.Sharma@....com>, 
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>, 
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

Applied.  Thanks!

On Sun, Apr 28, 2024 at 9:32 PM Zhou, Bob <Bob.Zhou@....com> wrote:
>
> [Public]
>
> Reviewed-by: Bob Zhou <bob.zhou@....com>
>
> Regards,
> Bob
>
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...aro.org>
> Sent: 2024年4月28日 20:57
> To: Zhou, Bob <Bob.Zhou@....com>
> Cc: Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; Pan, Xinhui <Xinhui.Pan@....com>; David Airlie <airlied@...il.com>; Daniel Vetter <daniel@...ll.ch>; Kuehling, Felix <Felix.Kuehling@....com>; Zhang, Hawking <Hawking.Zhang@....com>; Guchun Chen <guchun.chen@....com>; Ma, Le <Le.Ma@....com>; Lazar, Lijo <Lijo.Lazar@....com>; Sharma, Shashank <Shashank.Sharma@....com>; amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()
>
> The "instance" variable needs to be signed for the error handling to work.
>
> Fixes: b34ddc71267a ("drm/amdgpu: add error handle to avoid out-of-bounds")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 101038395c3b..772604feb6ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2017,7 +2017,7 @@ static int sdma_v4_0_process_trap_irq(struct amdgpu_device *adev,
>                                       struct amdgpu_irq_src *source,
>                                       struct amdgpu_iv_entry *entry)  {
> -       uint32_t instance;
> +       int instance;
>
>         DRM_DEBUG("IH: SDMA trap\n");
>         instance = sdma_v4_0_irq_id_to_seq(entry->client_id);
> --
> 2.43.0
>