linux-kernel - Re: [PATCH] init: replace deprecated strncpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171441134708.2359415.3239349305778672892.b4-ty@chromium.org>
Date: Mon, 29 Apr 2024 10:22:28 -0700
From: Kees Cook <keescook@...omium.org>
To: linux-kernel@...r.kernel.org,
	Justin Stitt <justinstitt@...gle.com>
Cc: Kees Cook <keescook@...omium.org>,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] init: replace deprecated strncpy with strscpy_pad

On Tue, 02 Apr 2024 20:39:49 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> data_page wants to be NUL-terminated and NUL-padded, use strscpy_pad to
> provide both of these. data_page no longer awkwardly relies on
> init_mount to perform its NUL-termination, although that sanity check is
> left unchanged.
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] init: replace deprecated strncpy with strscpy_pad
      https://git.kernel.org/kees/c/fa6475acde9a

Take care,

-- 
Kees Cook