linux-kernel - RE: [PATCH v5 2/3] mmc: block: register RPMB partition with the RPMB subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB6575AC5DEB3A46D1AE11705FFC1B2@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Mon, 29 Apr 2024 19:36:44 +0000
From: Avri Altman <Avri.Altman@....com>
To: Jens Wiklander <jens.wiklander@...aro.org>, Manuel Traut <manut@...ka.net>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"op-tee@...ts.trustedfirmware.org" <op-tee@...ts.trustedfirmware.org>, Shyam
 Saini <shyamsaini@...ux.microsoft.com>, Ulf Hansson <ulf.hansson@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>, Jerome Forissier
	<jerome.forissier@...aro.org>, Sumit Garg <sumit.garg@...aro.org>, Ilias
 Apalodimas <ilias.apalodimas@...aro.org>, Bart Van Assche
	<bvanassche@....org>, Randy Dunlap <rdunlap@...radead.org>, Ard Biesheuvel
	<ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Tomas Winkler <tomas.winkler@...el.com>,
	Alexander Usyskin <alexander.usyskin@...el.com>
Subject: RE: [PATCH v5 2/3] mmc: block: register RPMB partition with the RPMB
 subsystem

> > > >
> > > > Is it possible that idata->buf is not DMA capable? Any other ideas?
> > >
> > > Thanks for testing. I don't know, the idata->buf is allocated using
> > > alloc_pages_exact(nr_pages * PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); in
> > > optee_pool_op_alloc_helper().
> >
> > Is this really true for idata->buf or isnt the complete RPMB frame
> > memory allocated like this and therefore idata->buf not page aligned?
> 
> You're right.
Maybe add an assert of PAGE_ALIGNED(idata->buf)?

Thanks,
Avri

> 
> >
> > For RPMB via tee-supplicant the idata->buf is allocated within
> > memdup_user and therefore page aligned.
> 
> Yes, that's a difference. Have you tested with page-aligned buffers to see if it
> helps?