linux-kernel - Re: [PATCH 0/3] iio: adc: ad799x: Fix warning generated by checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240429205831.662da28a@jic23-huawei>
Date: Mon, 29 Apr 2024 20:58:31 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: ogustavo@....br, lars@...afoo.de, Michael.Hennerich@...log.com,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] iio: adc: ad799x: Fix warning generated by
 checkpatch

On Mon, 29 Apr 2024 09:28:25 +0200
Nuno Sá <noname.nuno@...il.com> wrote:

> On Sun, 2024-04-28 at 16:43 -0300, ogustavo@....br wrote:
> > From: Gustavo Rodrigues <ogustavo@....br>
> > 
> > Clean code of iio:adc:ad799x to cease warning messages pointed by
> > checkpatch. These include proper variable declaration 'unsigned' to 
> > 'unsigned int', add blank line and use of octal permission instead of 
> > symbolic.
> > 
> > Gustavo (3):
> >   iio: adc: ad799x: change 'unsigned' to 'unsigned int' declaration
> >   iio: adc: ad799x.c: add blank line to avoid warning messages
> >   iio: adc: ad799x: Prefer to use octal permission instead of symbolic
> > 
> >  drivers/iio/adc/ad799x.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >   
> 
> Patches look good. Just one note... It seems Marcelo gave some feedback on a
> previous iterations so it looks like this should have been marked as v2?
> 
> Anyways,
> 
> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> 

Indeed on v2.  Anyhow, applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to see if we missed anything,

Thanks,

Jonathan