linux-kernel - Re: [PATCH] parport: amiga: Mark driver struct with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wgsua47zswruupzxsmi5dr42oyhxqygbuh4de63k2lbqejevx4@e4adtgy4syif>
Date: Mon, 29 Apr 2024 22:30:47 +0200
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc: linux-kernel@...r.kernel.org, kernel@...gutronix.de, 
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] parport: amiga: Mark driver struct with __refdata to
 prevent section mismatch

Hello,

On Mon, Apr 15, 2024 at 04:37:44PM +0200, Uwe Kleine-König wrote:
> On Fri, Mar 29, 2024 at 10:54:39PM +0100, Uwe Kleine-König wrote:
> > As described in the added code comment, a reference to .exit.text is ok
> > for drivers registered via module_platform_driver_probe(). Make this
> > explicit to prevent the following section mismatch warning
> > 
> > 	WARNING: modpost: drivers/parport/parport_amiga: section mismatch in reference: amiga_parallel_driver+0x8 (section: .data) -> amiga_parallel_remove (section: .exit.text)
> > 
> > that triggers on an allmodconfig W=1 build.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> I'd like to enable these warnings even for W=0 builds, so it would be
> great to get it into the main line soon.
> 
> If you apply it, please notice that I fat-fingered the parameters to git
> send-email and it was sent in a thread. So (assuming you're using b4)
> you'd need:
> 
>         b4 am -P _ -v1 49ab91032bf9b57cd5fb6d306c38884d059dce2f.1711748999.git.u.kleine-koenig@...gutronix.de

Gentle ping!? It would be great to get this patch in during the
upcoming merge window.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)